Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Debian 12 #11228

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Add support for Debian 12 #11228

merged 5 commits into from
Oct 30, 2023

Conversation

prensing
Copy link

Description:

I have tried to add support for Debian 12. This is mostly a copy of the files from Debian 11. However, I found a few problems with some of the shared tests and tried to clean up the YAML/Jinja. The simple tests work for my plain Debian12 machine.

Rationale:

Debian 12 now out for about 1/2 year.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Oct 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

Hi @prensing. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 27, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership'.
--- xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership
+++ xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership
@@ -4,22 +4,15 @@
 
 [description]:
 The group-owner of all log files written by
-rsyslog should be
-
-root.
-
+rsyslog should be root.
 These log files are determined by the second part of each Rule line in
 /etc/rsyslog.conf and typically all appear in /var/log.
 For each log file LOGFILE referenced in /etc/rsyslog.conf,
 run the following command to inspect the file's group owner:
 $ ls -l LOGFILE
-If the owner is not
-
-root,
-
+If the owner is not root,
 run the following command to
 correct this:
-
 $ sudo chgrp root LOGFILE
 
 [reference]:

OCIL for rule 'xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership' differs.
--- ocil:ssg-rsyslog_files_groupownership_ocil:questionnaire:1
+++ ocil:ssg-rsyslog_files_groupownership_ocil:questionnaire:1
@@ -1,7 +1,5 @@
 The group-owner of all log files written by rsyslog should be
-
 root.
-
 These log files are determined by the second part of each Rule line in
 /etc/rsyslog.conf and typically all appear in /var/log.
 To see the group-owner of a given log file, run the following command:

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Oct 27, 2023
@prensing
Copy link
Author

Just pulled in the latest from master and fixed a conflict.

@Mab879 Mab879 added New Product Issues or pull requests related to new Products. Highlight This PR/Issue should make it to the featured changelog. labels Oct 27, 2023
@Mab879 Mab879 self-assigned this Oct 27, 2023
@Mab879 Mab879 added this to the 0.1.71 milestone Oct 27, 2023
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Please take a look at my comments, they shouldn't be too hard to fix. Secondly, please rebase your branch to remove the merge commit.

products/debian12/product.yml Outdated Show resolved Hide resolved
products/debian12/transforms/constants.xslt Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Oct 30, 2023

Code Climate has analyzed commit c2b0788 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.4%.

View more on Code Climate.

@prensing prensing requested a review from Mab879 October 30, 2023 13:33
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I'm waving SLE15 as failures are not related to this PR.

@Mab879 Mab879 merged commit b9e0292 into ComplianceAsCode:master Oct 30, 2023
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Highlight This PR/Issue should make it to the featured changelog. needs-ok-to-test Used by openshift-ci bot. New Product Issues or pull requests related to new Products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants