-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Debian 12 #11228
Add support for Debian 12 #11228
Conversation
Hi @prensing. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership'.
--- xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership
+++ xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership
@@ -4,22 +4,15 @@
[description]:
The group-owner of all log files written by
-rsyslog should be
-
-root.
-
+rsyslog should be root.
These log files are determined by the second part of each Rule line in
/etc/rsyslog.conf and typically all appear in /var/log.
For each log file LOGFILE referenced in /etc/rsyslog.conf,
run the following command to inspect the file's group owner:
$ ls -l LOGFILE
-If the owner is not
-
-root,
-
+If the owner is not root,
run the following command to
correct this:
-
$ sudo chgrp root LOGFILE
[reference]:
OCIL for rule 'xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership' differs.
--- ocil:ssg-rsyslog_files_groupownership_ocil:questionnaire:1
+++ ocil:ssg-rsyslog_files_groupownership_ocil:questionnaire:1
@@ -1,7 +1,5 @@
The group-owner of all log files written by rsyslog should be
-
root.
-
These log files are determined by the second part of each Rule line in
/etc/rsyslog.conf and typically all appear in /var/log.
To see the group-owner of a given log file, run the following command: |
Just pulled in the latest from master and fixed a conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
Please take a look at my comments, they shouldn't be too hard to fix. Secondly, please rebase your branch to remove the merge commit.
Code Climate has analyzed commit c2b0788 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.4%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I'm waving SLE15 as failures are not related to this PR.
Description:
I have tried to add support for Debian 12. This is mostly a copy of the files from Debian 11. However, I found a few problems with some of the shared tests and tried to clean up the YAML/Jinja. The simple tests work for my plain Debian12 machine.
Rationale:
Debian 12 now out for about 1/2 year.