Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference validation in OVAL document object #11235

Merged

Conversation

Honny1
Copy link
Collaborator

@Honny1 Honny1 commented Nov 1, 2023

Description:

This PR creates a method that checks if all component references are present in an OVAL document. This PR also changes the product argument of the load_shorthand method in the OVALDocument class to an optional argument.

Rationale:

This PR is part of the modifications to the OVAL object model for integration into the combine_ovals.py script.

Review Hints:

You can use the test suite run with tox to test the changes.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 1, 2023
Copy link

openshift-ci bot commented Nov 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Honny1 Honny1 added enhancement General enhancements to the project. Infrastructure Our content build system OVAL OVAL update. Related to the systems assessments. labels Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Honny1 Honny1 marked this pull request as ready for review November 1, 2023 09:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 1, 2023
Copy link

codeclimate bot commented Nov 1, 2023

Code Climate has analyzed commit 0a57827 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

@jan-cerny jan-cerny added this to the 0.1.71 milestone Nov 1, 2023
@jan-cerny jan-cerny self-assigned this Nov 1, 2023
@jan-cerny jan-cerny changed the title Reference validation in OVAL docuemnt object Reference validation in OVAL document object Nov 1, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the unit test passes for me. Thanks for this improvement.

@jan-cerny jan-cerny merged commit bb63938 into ComplianceAsCode:master Nov 2, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancements to the project. Infrastructure Our content build system OVAL OVAL update. Related to the systems assessments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants