New Rules Must Have a prodtype
#11252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
jan-cerny
reviewed
Nov 8, 2023
There was a problem hiding this comment.
It works as expected. I have removed prodtype from 2 random rules and it detected it and failed.
1/2 Test #9: test-rule-dir-json .................... Passed 15.32 sec
test 39
Start 39: test-no-new-global-applicable-rules
39: Test command: /usr/bin/env "PYTHONPATH=/home/jcerny/work/git/scap-security-guide" "/usr/bin/python3" "/home/jcerny/work/git/scap-security-guide/utils/no_new_global_applicable_rules.py" "--root" "/home/jcerny/work/git/scap-security-guide" "--json" "/home/jcerny/work/git/scap-security-guide/build/rule_dirs.json"
39: Working Directory: /home/jcerny/work/git/scap-security-guide/build/tests
39: Test timeout computed to be: 10000000
39: Rule service_timesyncd_root_distance_configured doesn't have a prodtype and it is expected to. You must add one.
39: Rule service_timesyncd_configured doesn't have a prodtype and it is expected to. You must add one.
2/2 Test #39: test-no-new-global-applicable-rules ...***Failed 0.26 sec
The following tests passed:
test-rule-dir-json
50% tests passed, 1 tests failed out of 2
Label Time Summary:
quick = 15.32 sec*proc (1 test)
Total Test time (real) = 15.59 sec
The following tests FAILED:
39 - test-no-new-global-applicable-rules (Failed)
Errors while running CTest
jan-cerny
approved these changes
Nov 8, 2023
To ensure that people are noticed before CI.
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/packit retest-failed |
jan-cerny
requested changes
Nov 9, 2023
| return expected_set | ||
|
|
||
|
|
||
| def _get_current_noprodtypes(rule_dirs): |
There was a problem hiding this comment.
Code Climate wants you to simplify this function
|
Code Climate has analyzed commit de666d5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.8%. View more on Code Climate. |
jan-cerny
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
jcerny@fedora ~/work/git/scap-security-guide/build (pr/11252) $ ctest --output-on-failure -R test-no-new-global-applicable-rules
Test project /home/jcerny/work/git/scap-security-guide/build
Start 6: test-rule-dir-json
1/2 Test #6: test-rule-dir-json .................... Passed 15.69 sec
Start 25: test-no-new-global-applicable-rules
2/2 Test #25: test-no-new-global-applicable-rules ...***Failed 0.27 sec
Rule service_timesyncd_configured doesn't have a prodtype and it is expected to. You must add one.
50% tests passed, 1 tests failed out of 2
Label Time Summary:
quick = 15.69 sec*proc (1 test)
Total Test time (real) = 15.97 sec
The following tests FAILED:
25 - test-no-new-global-applicable-rules (Failed)
Errors while running CTest
jcerny@fedora ~/work/git/scap-security-guide/build (pr/11252) $
Thanks for this great improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds a test that checks
Rationale:
This will be helpful in the future when we move prodtypes.
Review Hints:
Remove a prodtype rule and watch the new test fail.