Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to enable the logging of the combine_oval.py script #11260

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

Honny1
Copy link
Collaborator

@Honny1 Honny1 commented Nov 8, 2023

Description:

This PR enables debug and info messages while the combine_oval.py script is running if the build is run as a debug build.

Review Hints:

run the build using the following command:

./build_product --log fedora

@Honny1 Honny1 added Infrastructure Our content build system New Feature Issues or pull requests related to new Features. labels Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@jan-cerny
Copy link
Collaborator

This is slightly unfortunate, because of the description of the --debug option:

--debug, --no-debug: Make a debug build with draft profiles (off by default)

Are we OK with this or should the option be split into 2 options where the first turns on logging and the second turns on draft profiles?

@jan-cerny jan-cerny self-assigned this Nov 10, 2023
@Honny1
Copy link
Collaborator Author

Honny1 commented Nov 13, 2023

@jan-cerny I think a separate option would be ideal.

Copy link

codeclimate bot commented Nov 13, 2023

Code Climate has analyzed commit ccc2914 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.8%.

View more on Code Climate.

@jan-cerny jan-cerny added this to the 0.1.71 milestone Nov 16, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have executed the build of the rhel9 product both with and without the -l option and the output is expected.

@jan-cerny jan-cerny merged commit 4fde7e7 into ComplianceAsCode:master Nov 16, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system New Feature Issues or pull requests related to new Features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants