Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prodtype Required in JSON Schema #11281

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Nov 15, 2023

Description:

Make the prodype section required in the JSON Schema.

Since this is only a developer tool this shouldn't causes issues as it only show up as a warning in a participating developer's IDE.

Rationale:

Per the style guide make the prodtype now required in JSON schema.

The JSON  schema is only used for developer tooling and attention should be
drawn to the fact that the rule doesn't have a prodtype.
@Mab879 Mab879 added the Infrastructure Our content build system label Nov 15, 2023
@Mab879 Mab879 added this to the 0.1.71 milestone Nov 15, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@vojtapolasek vojtapolasek self-assigned this Nov 16, 2023
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the failing test is unrelated.

@vojtapolasek vojtapolasek merged commit cf88abb into ComplianceAsCode:master Nov 21, 2023
35 of 36 checks passed
@Mab879 Mab879 deleted the fix_schema_rule branch November 28, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants