-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and modify UBTU-20-010463 (no_empty_passwords) #11282
Conversation
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- Fix for original remediation which removed the `nullok` keyword and everything after it - Modification of STIG rule to include removing nullok also from /etc/pam.d/common-auth Rationale for modifying UBTU-20-010463: - /etc/pam.d/common-password does not contain nullok by default, nor does the keyword have any effect on changing passwords with `passwd` (empty passwords are not allowed with or without nullok keyword) - /etc/pam.d/common-auth contains nullok by default and thus allows logins to accounts with empty passwords DISA was notified of the issue. Some concerns were raised regarding effect on multifactor authentication, however, it was shown to work regardless of nullok keyword being present in /etc/pam.d/common-auth:pam_unix.so or not.
d4e0641
to
59c5fd8
Compare
Code Climate has analyzed commit eed70c3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.8%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Description:
nullok
keyword and everything after itRationale for modifying UBTU-20-010463:
does the keyword have any effect on changing passwords with
passwd
(empty passwords are not allowed with or without nullok keyword)
logins to accounts with empty passwords
DISA was notified of the issue. Some concerns were raised regarding effect on
multifactor authentication, however, it was shown to work regardless of
nullok keyword being present in /etc/pam.d/common-auth:pam_unix.so or
not.