Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken test for Ubuntu in template kernel_module_disabled #11288

Merged

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 20, 2023

Description:

  • Remove broken test for Ubuntu in template kernel_module_disabled

Rationale:

  • Test uses /etc/modprobe.conf which is not present on Ubuntu

/etc/modprobe.conf is not used in Ubuntu
Copy link

openshift-ci bot commented Nov 20, 2023

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 20, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@mpurg mpurg changed the title Remove broken test for Ubuntu in rule kernel_module_disabled Remove broken test for Ubuntu in template kernel_module_disabled Nov 20, 2023
Copy link

codeclimate bot commented Nov 20, 2023

Code Climate has analyzed commit 9f3740d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.8%.

View more on Code Climate.

@marcusburghardt marcusburghardt added the Ubuntu Ubuntu product related. label Nov 20, 2023
@marcusburghardt marcusburghardt added this to the 0.1.71 milestone Nov 20, 2023
@marcusburghardt marcusburghardt added the Test Suite Update in Test Suite. label Nov 20, 2023
@dodys dodys merged commit 117b7be into ComplianceAsCode:master Nov 21, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Test Suite Update in Test Suite. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants