controleval.py: Return empty list when parameter is not found #11300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_parameter_from_yaml()` doesn't handle KeyErrors. This changes the function to return an empty list when the section is not found. It could also return `None`, but the expected return type is list. Profiles with no `selections` are extending another profile, let's not count the control usage multiple times.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 6c6bed7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5%. View more on Code Climate. |
marcusburghardt
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It could also return
None, but the expected return type is list.Rationale:
get_parameter_from_yaml()doesn't handle KeyErrors.selectionsare known to be extending another profile, let's not count the control usage multiple times and considerselectionsas empty.Review Hints:
Github Pages / Publish stats, tables and guidesAction is failing on Add profile aliases for OpenShift versioned profiles #11241