-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable sshd_distributed_config for ubuntu 2004 & 2204 #11305
enable sshd_distributed_config for ubuntu 2004 & 2204 #11305
Conversation
Hi @paulroche. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/packit retest-failed |
hey @paulroche thanks for your PR. |
@dodys added ubuntu 2004 and updated platform string in sshd_lineinfile/tests. it appears the testing-farm tests are failing with:
im not sure how my changes to ubuntu could be impacting centos ability to remove ansible |
/packit retest-failed |
Code Climate has analyzed commit 7ba5686 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5%. View more on Code Climate. |
@marcusburghardt are the packit tests currently broken? |
Yes, we are investigating this. Hopefully we can solve it soon. If the PR is ready to be merged and we are sure no issue could be obfuscated by these broken tests, we can waive them in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
/packit retest-failed |
Description:
Rationale:
https://manpages.ubuntu.com/manpages/jammy/en/man5/sshd_config.5.html
https://manpages.ubuntu.com/manpages/focal/en/man5/sshd_config.5.html
Review Hints:
from my local testing:
without: