enable sshd_distributed_config for ubuntu 2004 & 2204

[paulroche]

Description:

• enable sshd_distributed_config for ubuntu 2004 & 2204

Rationale:

• default sshd config references a distributed config directory
  https://manpages.ubuntu.com/manpages/jammy/en/man5/sshd_config.5.html
  https://manpages.ubuntu.com/manpages/focal/en/man5/sshd_config.5.html

Review Hints:

from my local testing:

oscap-ssh --sudo ubuntu@test-host 22 xccdf eval --profile xccdf_org.ssgproject.content_profile_cis_level1_server --check-engine-results --rule xccdf_org.ssgproject.content_rule_sshd_disable_empty_passwords /scap-security-guide/ssg-ubuntu2204-sshd-ds.xml

Title   Disable SSH Access via Empty Passwords
Rule    xccdf_org.ssgproject.content_rule_sshd_disable_empty_passwords
Result  pass

without:

oscap-ssh --sudo ubuntu@test-host 22 xccdf eval --profile xccdf_org.ssgproject.content_profile_cis_level1_server --check-engine-results --rule xccdf_org.ssgproject.content_rule_sshd_disable_empty_passwords /scap-security-guide/ssg-ubuntu2204-ds.xml

Title   Disable SSH Access via Empty Passwords
Rule    xccdf_org.ssgproject.content_rule_sshd_disable_empty_passwords
Result  fail

[openshift-ci]

Hi @paulroche. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

[dodys]

/packit retest-failed

[dodys]

hey @paulroche thanks for your PR.
Would you like to include the same for Ubuntu 20.04 and if possible add multi_platform_ubuntu to missing tests in shared/templates/sshd_lineinfile/tests/ ?

[paulroche]

@dodys added ubuntu 2004 and updated platform string in sshd_lineinfile/tests. it appears the testing-farm tests are failing with:

:: [ 19:02:53 ] :: [ FAIL ] :: Command 'yum remove -y ansible' (Expected 0, got 1)

im not sure how my changes to ubuntu could be impacting centos ability to remove ansible

[dodys]

/packit retest-failed

[codeclimate]

Code Climate has analyzed commit 7ba5686 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

[dodys]

@marcusburghardt are the packit tests currently broken?

[marcusburghardt]

@marcusburghardt are the packit tests currently broken?

Yes, we are investigating this. Hopefully we can solve it soon. If the PR is ready to be merged and we are sure no issue could be obfuscated by these broken tests, we can waive them in the meantime.

[dodys]

lgtm, thanks!

[dodys]

/packit retest-failed