Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OL8 stig selection for OL08-00-040259 #11312

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Update OL8 stig selection for OL08-00-040259 #11312

merged 1 commit into from
Dec 1, 2023

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Nov 28, 2023

Description:

  • Replaced rule sysctl_net_ipv4_ip_forward with sysctl_net_ipv4_conf_all_forwarding in STIG profile to cover OL08-00-040259 requirement.

Rationale:

  • The rule sysctl_net_ipv4_conf_all_forwarding is actually the one that covers the requirement

@Xeicker
Update OL8 stig selection for OL08-00-040259
508c520 
The rule sysctl_net_ipv4_conf_all_forwarding is actually the one that
covers the requirement

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker Xeicker requested a review from a team as a code owner November 28, 2023 19:37
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 28, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 28, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 28, 2023

Code Climate has analyzed commit 508c520 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

@Mab879 Mab879 self-assigned this Nov 28, 2023
@Mab879 Mab879 added this to the 0.1.72 milestone Nov 28, 2023
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Nov 28, 2023
@Mab879
Copy link
Member

Mab879 commented Nov 30, 2023

/packit retest-failed

2 similar comments
@Mab879
Copy link
Member

Mab879 commented Dec 1, 2023

/packit retest-failed

@Mab879
Copy link
Member

Mab879 commented Dec 1, 2023

/packit retest-failed

Mab879
Mab879 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Overriding CODEOWNERS due to no Oracle owners available.

@Mab879 Mab879 enabled auto-merge December 1, 2023 17:36
auto-merge was automatically disabled December 1, 2023 18:48

Merge queue setting changed

@Mab879 Mab879 merged commit 27c8eca into ComplianceAsCode:master Dec 1, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
needs-ok-to-test Used by openshift-ci bot. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.72
Development

Successfully merging this pull request may close these issues.
2 participants
@Xeicker @Mab879