Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShellCheck Issues in CPE Checks #11322

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Nov 30, 2023

Description:

Fix two CPE issues in CPE checks

Rationale:

Fix ctest errors

Review Hints:

Build the OL8 product and run the tests.

@Mab879 Mab879 added the Bash Bash remediation update. label Nov 30, 2023
@Mab879 Mab879 added this to the 0.1.72 milestone Nov 30, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 30, 2023

Code Climate has analyzed commit 58294d8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

@jan-cerny
Copy link
Collaborator

/packit retest-failed

@jan-cerny jan-cerny self-assigned this Dec 1, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this change fixes the failing test ol8-bash-shellcheck.

@jan-cerny
Copy link
Collaborator

/packit retest-failed

@jan-cerny jan-cerny merged commit e6338da into ComplianceAsCode:master Dec 1, 2023
38 checks passed
@Mab879 Mab879 deleted the fix_ol8_shellcheck branch December 1, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants