Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rules STIG UBTU-20-010437 and UBTU-20-010451 #11325

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Add rules STIG UBTU-20-010437 and UBTU-20-010451 #11325

merged 5 commits into from
Dec 5, 2023

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Dec 1, 2023 •
edited
Loading

Description:

Rationale:

  • Template in original PR (lineinfile) did not check for or remediate existing wrong values.

dexterle and others added 5 commits December 1, 2023 12:41
@dexterle @mpurg
add aide_disable_silentreports rule for UBTU-20-010437
0691afd 
This commit will add in rule for UBTU-20-010437 which ensures to update aide configurations along with tests to be utilized. Additionally, a rule is created utilizing the lineinfile template.
@mpurg
Remove trailing whitespaces
0e7e281
@mpurg
Added comment for UBTU-20-010451
fbbadbc 
Same rule as UBTU-20-010437. Notified DISA.
@mpurg
Fixed tests for aide_disable_silentreports
d8ce311
@mpurg
Change template for 'aide_disable_silentreports'
20be8bc 
Switch to template `key_value_pair_in_file` for rule `aide_disable_silentreports`.
Previously used template `lineinfile` only checked for lines containing
correct key value pairs (`key=value`).
It did not check for or remediate existing wrong values.
@mpurg mpurg requested a review from a team as a code owner December 1, 2023 11:47
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 1, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 1, 2023

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu1804 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879
Copy link
Member

Mab879 commented Dec 1, 2023

/packit retest-failed

@dodys dodys mentioned this pull request Dec 1, 2023
Closed
@dodys dodys self-assigned this Dec 5, 2023
@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Dec 5, 2023
dodys
dodys approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 4296f7a into ComplianceAsCode:master Dec 5, 2023
33 of 38 checks passed
@Mab879 Mab879 added this to the 0.1.72 milestone Dec 5, 2023
@Mab879 Mab879 added Ubuntu Ubuntu product related. STIG STIG Benchmark related. New Rule Issues or pull requests related to new Rules. labels Dec 5, 2023
@dodys dodys mentioned this pull request Dec 7, 2023
Closed
@vojtapolasek vojtapolasek added the Update Profile Issues or pull requests related to Profiles updates. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels
New Rule Issues or pull requests related to new Rules. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.72
Development

Successfully merging this pull request may close these issues.
5 participants
@mpurg @Mab879 @dodys @vojtapolasek @dexterle