Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package_firewalld_installed to RHEL 9 CIS #11351

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Dec 5, 2023

Description:

Add rule package_firewalld_installed to the RHEL 9 CIS profile.

Rationale:

Closes #11340

@Mab879 Mab879 added RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Dec 5, 2023
@Mab879 Mab879 added this to the 0.1.72 milestone Dec 5, 2023
@Mab879 Mab879 requested a review from a team as a code owner December 5, 2023 19:49
Copy link

github-actions bot commented Dec 5, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Dec 5, 2023

Code Climate has analyzed commit 73adefa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Dec 6, 2023
@marcusburghardt
Copy link
Member

/packit test

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait the CI tests to finish.

@Mab879
Copy link
Member Author

Mab879 commented Dec 6, 2023

/packit rebuild-failed

@marcusburghardt marcusburghardt merged commit bbe417f into ComplianceAsCode:master Dec 7, 2023
37 of 38 checks passed
@Mab879 Mab879 deleted the fix_11340 branch December 7, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule package_firewalld_installed is missing in CIS profile for RHEL9
2 participants