Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes update-oscal.yml to remove env context from matrix variables #11374

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented Dec 12, 2023

Description:

Using the env context is not supported in the matrix variables setup by the actions/runner.

Rationale:

The env context was used here to reduce duplication, but it is not supported in this location by the actions/runner. Since each string is only used in two places, I added it directly to the variables in the matrix.

Review Hints:

Tested and verified that the workflow file is valid using workflow dispatch trigger here - https://github.com/jpower432/content/actions/runs/7182837347

Using the env context is not supported in the matrix variables setup
by the actions/runner

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 12, 2023
Copy link

openshift-ci bot commented Dec 12, 2023

Hi @jpower432. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Dec 12, 2023
@Mab879 Mab879 added this to the 0.1.72 milestone Dec 12, 2023
@Mab879 Mab879 added the Infrastructure Our content build system label Dec 12, 2023
Copy link

codeclimate bot commented Dec 12, 2023

Code Climate has analyzed commit 2539c50 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 42f7499 into ComplianceAsCode:master Dec 12, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSCAL Import Job Fails When Ran
2 participants