Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bogus specifier from audit_rules_privileged_commands_unix2_chkpwd #11379

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

evgenyz
Copy link
Member

@evgenyz evgenyz commented Dec 13, 2023

Description:

This sle15 specifier is redundant and goes against the build system rules.

Rationale:

In a situation when rule's prodtype would be expanded build will fail.

rule's template

This sle15 specifier is redundant and goes against the build system rules.
@evgenyz evgenyz added the Infrastructure Our content build system label Dec 13, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

sle15 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Dec 13, 2023

Code Climate has analyzed commit 42b9a7a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule is only used by sle15 and this would be updated if the rule would adopted by other products. But the specifier is indeed not necessary now.

@marcusburghardt
Copy link
Member

Automatus tests for CS8 and CS9 are failing because the rule is restricted to sle15.

@marcusburghardt marcusburghardt merged commit 0ee73d9 into ComplianceAsCode:master Dec 13, 2023
35 of 37 checks passed
@marcusburghardt marcusburghardt self-assigned this Dec 13, 2023
@evgenyz evgenyz deleted the fix-tpl-param branch December 13, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants