-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename inconsistent shared OVAL IDs (Oracle Linux) #11392
Rename inconsistent shared OVAL IDs (Oracle Linux) #11392
Conversation
The ID are not uniform with other similar checks (RHEL, SUSE, Fedora etc), but there is no reason for them to be unique.
This datastream diff is auto generated by the check Click here to see the full diffOVAL for rule 'xccdf_org.ssgproject.content_rule_installed_OS_is_FIPS_certified' differs.
--- oval:ssg-installed_OS_is_FIPS_certified:def:1
+++ oval:ssg-installed_OS_is_FIPS_certified:def:1
@@ -2,7 +2,7 @@
extend_definition oval:ssg-installed_OS_is_rhel7:def:1
extend_definition oval:ssg-installed_OS_is_rhel8:def:1
extend_definition oval:ssg-installed_OS_is_rhcos4:def:1
-extend_definition oval:ssg-installed_OS_is_ol7_family:def:1
+extend_definition oval:ssg-installed_OS_is_ol7:def:1
extend_definition oval:ssg-installed_OS_is_sle12:def:1
extend_definition oval:ssg-installed_OS_is_sle15:def:1
extend_definition oval:ssg-installed_OS_is_ubuntu1604:def:1
OVAL for rule 'xccdf_org.ssgproject.content_rule_installed_OS_is_vendor_supported' differs.
--- oval:ssg-installed_OS_is_vendor_supported:def:1
+++ oval:ssg-installed_OS_is_vendor_supported:def:1
@@ -2,7 +2,7 @@
extend_definition oval:ssg-installed_OS_is_rhel7:def:1
extend_definition oval:ssg-installed_OS_is_rhel8:def:1
extend_definition oval:ssg-installed_OS_is_rhel9:def:1
-extend_definition oval:ssg-installed_OS_is_ol7_family:def:1
-extend_definition oval:ssg-installed_OS_is_ol8_family:def:1
+extend_definition oval:ssg-installed_OS_is_ol7:def:1
+extend_definition oval:ssg-installed_OS_is_ol8:def:1
extend_definition oval:ssg-installed_OS_is_sle12:def:1
extend_definition oval:ssg-installed_OS_is_sle15:def:1 |
Code Climate has analyzed commit 122ecea and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ComplianceAsCode/oracle-maintainers PTAL
FYI @Xeicker |
Overriding CODEOWNERS since a Oracle approver is not currently available. |
Description:
The IDs are not uniform with other similar checks (RHEL, SUSE, Fedora etc), but there is no reason for them to be unique.
This is sort of a continuation of #11377.
Rationale:
prodtype
removalReview Hints: