Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alinux2/alinux3 support for pci-dss compliance #11398

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

rain-Qing
Copy link
Contributor

@rain-Qing rain-Qing commented Dec 19, 2023

Description:

Add files:

  • products/alinux2/profiles/pci-dss.profile
  • products/alinux3/profiles/pci-dss.profile

Add pci-dss.profile compliance to alinux2 and alinux3 products.

Signed-off-by: YuQing.Yang yangyuqing6@qq.com
Signed-off-by: YiLin.Li YiLin.Li@linux.alibaba.com

#11397

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 19, 2023
Copy link

openshift-ci bot commented Dec 19, 2023

Hi @rain-Qing. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

We were not able to find or create Copr project packit/ComplianceAsCode-content-11398 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=ComplianceAsCode-content-11398 chroots=['fedora-39-x86_64', 'epel-7-x86_64', 'fedora-rawhide-x86_64', 'fedora-38-x86_64', 'centos-stream-8-x86_64', 'centos-stream-9-x86_64']): Response is not in JSON format, there is probably a bug in the API code.

Please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Signed-off-by: YuQing.Yang <yangyuqing6@qq.com>
Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
Copy link

codeclimate bot commented Dec 20, 2023

Code Climate has analyzed commit 9043c59 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Dec 20, 2023
@jan-cerny jan-cerny added Alibaba Linux Alibaba Linux product related. pci-dss labels Dec 20, 2023
@jan-cerny jan-cerny added this to the 0.1.72 milestone Dec 20, 2023
@jan-cerny jan-cerny changed the title Add alinux2/alinux3 support for pci-dss compliance. Add alinux2/alinux3 support for pci-dss compliance Dec 20, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've built content for Alibaba Cloud Linux 2 and 3 and I have quickly seen the generated HTML guides for the PCI-DSS profiles.

@jan-cerny jan-cerny merged commit 41ad190 into ComplianceAsCode:master Dec 20, 2023
36 checks passed
@jan-cerny jan-cerny added the New Profile Issues or pull requests related to new Profiles. label Dec 20, 2023
@rain-Qing rain-Qing deleted the alinux branch January 25, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Alibaba Linux Alibaba Linux product related. needs-ok-to-test Used by openshift-ci bot. New Profile Issues or pull requests related to new Profiles. pci-dss
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants