Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anolis23/anolis8 support for pci-dss compliance. #11401

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

rain-Qing
Copy link
Contributor

Description:

Add files:

  • products/anolis23/profiles/pci-dss.profile
  • products/anolis8/profiles/pci-dss.profile

Add pci-dss.profile compliance to anolis23 and anolis8 products.

Signed-off-by: YuQing.Yang yangyuqing6@qq.com
Signed-off-by: YiLin.Li YiLin.Li@linux.alibaba.com

#11396

Signed-off-by: YuQing.Yang <yangyuqing6@qq.com>
Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
Copy link

openshift-ci bot commented Dec 20, 2023

Hi @rain-Qing. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 20, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Dec 20, 2023

Code Climate has analyzed commit 6863318 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added New Profile Issues or pull requests related to new Profiles. pci-dss labels Dec 20, 2023
@marcusburghardt
Copy link
Member

@rain-Qing and @hustliyilin there are some coverage gaps in the PCI-DSSv4 policy that any contribution is welcome. Since you are also adopting this control file, I invite you to contribute on some of these gaps. You can take a look in https://github.com/ComplianceAsCode/content/blob/master/controls/pcidss_4.yml , specially the requirements in pending and partial status and their respective notes.

1 similar comment
@marcusburghardt
Copy link
Member

@rain-Qing and @hustliyilin there are some coverage gaps in the PCI-DSSv4 policy that any contribution is welcome. Since you are also adopting this control file, I invite you to contribute on some of these gaps. You can take a look in https://github.com/ComplianceAsCode/content/blob/master/controls/pcidss_4.yml , specially the requirements in pending and partial status and their respective notes.

@marcusburghardt marcusburghardt added the Alibaba Linux Alibaba Linux product related. label Dec 20, 2023
@rain-Qing
Copy link
Contributor Author

rain-Qing commented Dec 20, 2023

@rain-Qing and @hustliyilin there are some coverage gaps in the PCI-DSSv4 policy that any contribution is welcome. Since you are also adopting this control file, I invite you to contribute on some of these gaps. You can take a look in https://github.com/ComplianceAsCode/content/blob/master/controls/pcidss_4.yml , specially the requirements in pending and partial status and their respective notes.

Well, we'd love to continue contributing to the repository.

Please also take time to review my code. @marcusburghardt

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcusburghardt marcusburghardt self-assigned this Dec 21, 2023
@marcusburghardt marcusburghardt added this to the 0.1.72 milestone Dec 21, 2023
@marcusburghardt marcusburghardt merged commit efb6e59 into ComplianceAsCode:master Dec 21, 2023
36 checks passed
@rain-Qing rain-Qing deleted the anolis branch January 25, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Alibaba Linux Alibaba Linux product related. needs-ok-to-test Used by openshift-ci bot. New Profile Issues or pull requests related to new Profiles. pci-dss
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants