Update test-check-eof for smoke test #11402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have recently add the `/.github` directory to the list of paths checked by `check_eof.py` as a part of the `test-check-eof` CTest test. The unpredicted consequence of this is that the smoke test in the downstream Fedora CI started to fail. The reason is that we don't ship the `/.github` directory as a part of our released tarball. It doesn't make sense to ship this directory as a part of the tarballs because this contains the upstream CI configurations etc. OTOH it makes sense to skip this directory when it isn't present. See for example the CI results of the smoke test in: https://src.fedoraproject.org/rpms/scap-security-guide/pull-request/34 Addressing: ``` 118/333 Test ComplianceAsCode#118: test-check-eof ...................................................***Failed 4.33 sec The path /root/rpmbuild/BUILD/scap-security-guide-0.1.71/.github does not exist! ```
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 5431965 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5% (0.0% change). View more on Code Climate. |
marcusburghardt
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently add the
/.githubdirectory to the list of paths checked bycheck_eof.pyas a part of thetest-check-eofCTest test. The unpredicted consequence of this is that the smoke test in the downstream Fedora CI started to fail. The reason is that we don't ship the/.githubdirectory as a part of our released tarball. It doesn't make sense to ship this directory as a part of the tarballs because this contains the upstream CI configurations etc. OTOH it makes sense to skip this directory when it isn't present.See for example the CI results of the smoke test in: https://src.fedoraproject.org/rpms/scap-security-guide/pull-request/34
Addressing: