Building on Windows #11406
Building on Windows #11406
Conversation
|
Hi @Commandcracker. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
/packit retest-failed |
| OPENSCAP_POSSIBLE_ROOT_DIRS = [ | ||
| os.getenv("OPENSCAP_ROOT_DIR"), | ||
| os.getenv("ProgramFiles"), | ||
| os.getenv("XSLT_PREFIX"), | ||
| "/usr", | ||
| "/usr/bin", | ||
| "/usr/sbin", | ||
| "/usr/local", | ||
| "/usr/share/", | ||
| "/usr/local/share", | ||
| "/opt", | ||
| "/opt/local", | ||
| ] | ||
|
|
||
| for root_dir in OPENSCAP_POSSIBLE_ROOT_DIRS: | ||
| if root_dir is None: | ||
| continue | ||
| for subpath in [os.path.join("share", "openscap", "xsl"), "xsl"]: | ||
| file_path = os.path.join(root_dir, subpath, "xccdf-guide.xsl") | ||
| if os.path.exists(file_path): | ||
| XCCDF_GUIDE_XSL = file_path | ||
| break | ||
| else: | ||
| continue | ||
| break | ||
| else: | ||
| XCCDF_GUIDE_XSL = None |
There was a problem hiding this comment.
If we want to do things correctly, the path should be found by CMake and then passed to the script as a parameter.
|
Code Climate has analyzed commit e3f471b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5% (0.0% change). View more on Code Climate. |
vojtapolasek
added
Highlight
Description:
The changes make it possible to build on Windows.
Requirements:
(all of them are obvious except for a xmllint port)