Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct HTML element for inline code #11408

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

jan-cerny
Copy link
Collaborator

@jan-cerny jan-cerny commented Dec 28, 2023

For inline code entries the <code> element should be used instead of the <pre> element which is a block element.

Using an incorrect element causes inappropriate formatting across our HTML guides and reports. This problem has been discovered during work on issue:
OpenSCAP/openscap-report#212

Before:
image

After:
image

For inline code entries the `<code>` element should be used instead
of the `<pre>` element which is a block element.

Using an incorrect element causes inappropriate formatting across our
HTML guides and reports. This problem has been discovered during work
on issue:
OpenSCAP/openscap-report#212
@jan-cerny jan-cerny added the Update Rule Issues or pull requests related to Rules updates. label Dec 28, 2023
@jan-cerny jan-cerny added this to the 0.1.72 milestone Dec 28, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Dec 28, 2023

Code Climate has analyzed commit cc560c7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@jan-cerny
Copy link
Collaborator Author

/packit retest-failed

1 similar comment
@jan-cerny
Copy link
Collaborator Author

/packit retest-failed

@Mab879 Mab879 self-assigned this Jan 2, 2024
@jan-cerny
Copy link
Collaborator Author

/packit retest-failed

@Mab879
Copy link
Member

Mab879 commented Jan 2, 2024

/packit rebuild-failed

@Mab879 Mab879 merged commit 39854d6 into ComplianceAsCode:master Jan 2, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants