-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: service_timesyncd_configured #11410
fix: service_timesyncd_configured #11410
Conversation
If timesync.d directory the script failed to apply
Hi @Whidix. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This datastream diff is auto generated by the check Click here to see the full diffbash remediation for rule 'xccdf_org.ssgproject.content_rule_service_timesyncd_configured' differs.
--- xccdf_org.ssgproject.content_rule_service_timesyncd_configured
+++ xccdf_org.ssgproject.content_rule_service_timesyncd_configured
@@ -18,6 +18,11 @@
sed -i 's/^NTP/#&/g' "$current_cfg"
sed -i 's/^FallbackNTP/#&/g' "$current_cfg"
done
+# Create /etc/systemd/timesyncd.d if it doesn't exist
+if [ ! -d "/etc/systemd/timesyncd.d" ]
+then
+ mkdir /etc/systemd/timesyncd.d
+fi
# Set primary fallback NTP servers in drop-in configuration
echo "NTP=$preferred_ntp_servers" >> "$config_file"
echo "FallbackNTP=$fallback_ntp_servers" >> "$config_file" |
# Create /etc/systemd/timesyncd.d if it doesn't exist | ||
if [ ! -d "/etc/systemd/timesyncd.d" ] | ||
then | ||
mkdir etc/systemd/timesyncd.d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mkdir etc/systemd/timesyncd.d | |
mkdir /etc/systemd/timesyncd.d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the full path to the mkdir
call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, my bad
Code Climate has analyzed commit 182a922 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5% (0.0% change). View more on Code Climate. |
@packbit rebuild-failed |
@packbit retest-failed |
/packit retest-failed |
If timesync.d directory does not exist the script failed to apply
Description: