-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate levels in controls #11427
Validate levels in controls #11427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please rewrite to that it works on Python 2.7 on CentOS 7.
727ec2c
to
990ea4d
Compare
in case there are no levels defined, insert there a default level
This function checks if all levels defined for individual controls are defined for the policy.
990ea4d
to
07687e7
Compare
Code Climate has analyzed commit 07687e7 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5% (0.1% change). View more on Code Climate. |
/packit retest |
/packit retest-failed |
/packit rebuild-failed |
1 similar comment
/packit rebuild-failed |
/packit retest-failed |
@Mab879 I think I fixed everything I could. I consider extracting code from controls.py to satisfy the requirement on number of lines as out of scope. |
Agreed. Thanks for the work. Reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for your work.
Description:
Rationale:
Inspired while verifying #11417
Review Hints: