Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align description of audit_rules_kernel_module_loading #11443

Merged
merged 2 commits into from
Jan 12, 2024
Merged

align description of audit_rules_kernel_module_loading #11443

merged 2 commits into from
Jan 12, 2024

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • add the part of the line restricting UIDs for RHEL* and OL* products
  • add OCIL macro for finit_module

Rationale:

  • aligns rule description with check and remediations
  • completes OCIL

Review Hints:

  • compile e.g. rhel9 and sle15 product
  • compare their remediations, check and rule description, differences should be the same

@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. RHEL Red Hat Enterprise Linux product related. Update Rule Issues or pull requests related to Rules updates. labels Jan 12, 2024
@vojtapolasek vojtapolasek added this to the 0.1.72 milestone Jan 12, 2024
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Jan 12, 2024
@jan-cerny
Copy link
Collaborator

/packit retest-failed

Mab879
Mab879 requested changes Jan 12, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor issue.

...uditd_configure_rules/audit_kernel_module_loading/audit_rules_kernel_module_loading/rule.yml Outdated Show resolved Hide resolved
@vojtapolasek vojtapolasek force-pushed the fix_audit_rules_kernel_module_loading_desc branch from 9329796 to 0dbfd4f Compare January 12, 2024 16:34
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 12, 2024

Code Climate has analyzed commit 0dbfd4f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

Mab879
Mab879 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Thanks!

@Mab879 Mab879 merged commit 4b67834 into ComplianceAsCode:master Jan 12, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
bugfix Fixes to reported bugs. RHEL Red Hat Enterprise Linux product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.72
Development

Successfully merging this pull request may close these issues.
3 participants
@vojtapolasek @jan-cerny @Mab879