Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RHEL 7 CIS Section 1 #11449

Merged
merged 43 commits into from
Jan 19, 2024
Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 16, 2024

Description:

Update RHEL 7 CIS 4 Section 1 to v4.

Rationale:

Keep the profile up-to-date.

@Mab879 Mab879 added Update Profile Issues or pull requests related to Profiles updates. RHEL7 Red Hat Enterprise Linux 7 product related. CIS CIS Benchmark related. labels Jan 16, 2024
@Mab879 Mab879 added this to the 0.1.72 milestone Jan 16, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 16, 2024
Copy link

openshift-ci bot commented Jan 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 marked this pull request as ready for review January 16, 2024 22:21
@Mab879 Mab879 requested a review from a team as a code owner January 16, 2024 22:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 16, 2024
@jan-cerny jan-cerny self-assigned this Jan 17, 2024
@@ -37,6 +37,42 @@ controls:
- kernel_module_cramfs_disabled

- id: 1.1.1.2
title: Ensure mounting of freevxfs filesystems is disabled (Automated)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slightly different title

Comment on lines 42 to 43
- l2_server
- l2_workstation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be l1

- kernel_module_freevxfs_disabled

- id: 1.1.1.3
title: Ensure mounting of hfs filesystems is disabled (Automated)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different title

- kernel_module_hfs_disabled

- id: 1.1.1.4
title: Ensure mounting of hfsplus filesystems is disabled (Automated)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different title

@@ -45,7 +81,7 @@ controls:
rules:
- kernel_module_squashfs_disabled

- id: 1.1.1.3
- id: 1.1.1.7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1.1.7 should be level 2

- id: 1.1.18
title: Ensure /home partition includes the nodev option (Automated)
- id: 1.1.2.5.3
title: Ensure /var/tmp partition includes the nosuid option (Automated)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title

- id: 1.1.19
title: Ensure removable media partitions include noexec option (Automated)
- id: 1.1.2.5.4
title: Ensure /var/tmp partition includes the noexec option (Automated)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title

- id: 1.1.20
title: Ensure nodev option set on removable media partitions (Automated)
- id: 1.1.2.6.2
title: Ensure /var/log partition includes the nodev option (Automated)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title

- id: 1.1.21
title: Ensure nosuid option set on removable media partitions (Automated)
- id: 1.1.2.6.3
title: Ensure /var/log partition includes the nosuid option (Automated)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title

- id: 1.1.22
title: Ensure sticky bit is set on all world-writable directories (Automated)
- id: 1.1.2.6.4
title: Ensure /var/log partition includes the noexec option (Automated)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title

Copy link

codeclimate bot commented Jan 18, 2024

Code Climate has analyzed commit 0eaeec4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@jan-cerny
Copy link
Collaborator

The CI fail on Rawhide is caused by aio-libs/multidict#926 and isn't related to the pull request.

@jan-cerny jan-cerny merged commit 1a16691 into ComplianceAsCode:master Jan 19, 2024
37 of 38 checks passed
@Mab879 Mab879 deleted the rhel7_cis_v4 branch January 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. RHEL7 Red Hat Enterprise Linux 7 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants