Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHEL7 CIS: align section 2 with the final version #11453

Merged
merged 32 commits into from
Jan 19, 2024
Merged

RHEL7 CIS: align section 2 with the final version #11453

merged 32 commits into from
Jan 19, 2024

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • make appropriate changes to the control file
  • align references with the control file
  • remove references from rules which were removed from the profile

Rationale:

Review Hints:

Download the CIS benchmark and check it against the control file.

@vojtapolasek vojtapolasek added Update Profile Issues or pull requests related to Profiles updates. RHEL7 Red Hat Enterprise Linux 7 product related. CIS CIS Benchmark related. labels Jan 17, 2024
@vojtapolasek vojtapolasek added this to the 0.1.72 milestone Jan 17, 2024
@vojtapolasek vojtapolasek requested a review from a team as a code owner January 17, 2024 15:36
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Jan 18, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 19, 2024

Code Climate has analyzed commit 0df51ac and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Jan 19, 2024

The failure on Fedora Rawhide can be waived since the failure is not caused by this PR.

Mab879
Mab879 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks.

@Mab879 Mab879 merged commit 909f710 into ComplianceAsCode:master Jan 19, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
CIS CIS Benchmark related. RHEL7 Red Hat Enterprise Linux 7 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.72
Development

Successfully merging this pull request may close these issues.
2 participants
@vojtapolasek @Mab879