Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tests/test_product_stability.py to be executed #11464

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 22, 2024

Description:

Allow tests/test_product_stability.py to be executed directly.

Rationale:

In the output it gives an example of how to update the data.
This PR makes it so the example can be used without modification.

Example output

If changes to mentioned products are intentional, execute this script with PYTHONPATH set to the project root to regenerate reference products:
/home/mburket/ComplianceAsCode/content/tests/test_product_stability.py --update-reference-data /home/mburket/ComplianceAsCode/content/products /home/mburket/ComplianceAsCode/content/tests/data/product_stability
If those changes are unwanted, take a look at product properties that likely cause these changes.

Review Hints:

./tests/test_product_stability.py

In the output it gives an example of how to update the data.
This commit makes it so the example can be used without modification.
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Jan 22, 2024

Code Climate has analyzed commit 9ee2b83 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.72 milestone Jan 22, 2024
@Mab879 Mab879 added the Infrastructure Our content build system label Jan 22, 2024
@jan-cerny jan-cerny self-assigned this Jan 23, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the script is executable now.

@jan-cerny
Copy link
Collaborator

/packit retest-failed

@jan-cerny jan-cerny changed the title Allow tests/test_product_stability.py to be executed. Allow tests/test_product_stability.py to be executed Jan 23, 2024
@jan-cerny jan-cerny merged commit 3d7aaf3 into ComplianceAsCode:master Jan 23, 2024
41 of 43 checks passed
@Mab879 Mab879 deleted the fix_test_product_stability branch January 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants