Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible: change the sysctl module fqcn for rhel7 product #11465

Merged

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • in case the full fqcn for sysctl module is used, use the ansible.builtin.sysctl when building for rhel7 product

Rationale:

Review Hints:

  • build the rhel7 product
  • provision RHEL 7 system
  • oscap xccdf generate fix --fix-type ansible--output ansible.yml --profile '(all)' ssg-rhel7-ds.xml
  • ansible-playbook --syntax-check ansible.yml

the version of Ansible shipped with RHEL 7 contains modules before the ansible.posix started being used
@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. Ansible Ansible remediation update. RHEL7 Red Hat Enterprise Linux 7 product related. labels Jan 22, 2024
@vojtapolasek vojtapolasek added this to the 0.1.72 milestone Jan 22, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel7 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_set_nftables_loopback_traffic' differs.
--- xccdf_org.ssgproject.content_rule_set_nftables_loopback_traffic
+++ xccdf_org.ssgproject.content_rule_set_nftables_loopback_traffic
@@ -54,7 +54,7 @@
   - set_nftables_loopback_traffic
 
 - name: Check sysctl value of net.ipv6.conf.all.disable_ipv6
-  ansible.posix.sysctl:
+  ansible.builtin.sysctl:
     name: net.ipv6.conf.all.disable_ipv6
     state: present
     value: '1'
@@ -72,7 +72,7 @@
   - set_nftables_loopback_traffic
 
 - name: Check sysctl value of net.ipv6.conf.default.disable_ipv6
-  ansible.posix.sysctl:
+  ansible.builtin.sysctl:
     name: net.ipv6.conf.default.disable_ipv6
     state: present
     value: '1'

Copy link

codeclimate bot commented Jan 22, 2024

Code Climate has analyzed commit cf23bd5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Jan 22, 2024
@Mab879
Copy link
Member

Mab879 commented Jan 22, 2024

/packit retest-failed

@Mab879
Copy link
Member

Mab879 commented Jan 23, 2024

Automatus failures can be waived as the failures are on clean up.

@Mab879 Mab879 merged commit ca52179 into ComplianceAsCode:master Jan 23, 2024
37 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. bugfix Fixes to reported bugs. RHEL7 Red Hat Enterprise Linux 7 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansible.posix is not found RHEL 7
2 participants