-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCP4: Fix pr image workflow #11533
OCP4: Fix pr image workflow #11533
Conversation
We don't have a way to test this workflow until we have this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vincent056 Would you like to incorporate these from https://github.com/ComplianceAsCode/content/pull/11531/files ?
5c04c0b
to
c287b14
Compare
There was a issue with existing pr image build workflow, github does not let workflow to use metal-toolbox/container-push/.github/workflows/container-push.yml@main in the steps, this PR replace metal-toolbox to build and push image directly
c287b14
to
7d9ba83
Compare
Code Climate has analyzed commit 7d9ba83 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR should not be affecting any build or test in centos-stream-9 |
There was an issue with the existing pr image build workflow, GitHub does not let workflow use metal-toolbox/container-push/.github/workflows/container-push.yml@main in the steps, this PR replaced metal-toolbox to build and push images directly.