-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate rule references from control files #11540
Generate rule references from control files #11540
Commits on Feb 5, 2024
-
Represent references as lists internally
The reference values are stored in rule.yml files as strings that are comma-separated lists of identifiers. We won't change the rule.yml files stored in git because that would be a massive change, but we will change the way how the references are stored internally in build system and also in the resolved files. This should simplify the code but won't have impact on built SCAP data streams.
Configuration menu - View commit details
-
Copy full SHA for 1f88d87 - Browse repository at this point
Copy the full SHA 1f88d87View commit details -
Extend control file schema to support references
With this change we will be able to use controls IDs as reference keys, which will allow us to add references to rules based on control files.
Configuration menu - View commit details
-
Copy full SHA for 7ca47cf - Browse repository at this point
Copy the full SHA 7ca47cfView commit details -
Add references from control files to rules
Starting from this change the references can be added to rules automatically based on control files control IDs.
Configuration menu - View commit details
-
Copy full SHA for 68c1558 - Browse repository at this point
Copy the full SHA 68c1558View commit details -
Add a one-off script to remove references
Remove references from rule.ymls
Configuration menu - View commit details
-
Copy full SHA for c352b30 - Browse repository at this point
Copy the full SHA c352b30View commit details -
Use references from control files
For RHEL CIS profiles we will used the control files as the source of reference data.
Configuration menu - View commit details
-
Copy full SHA for eafa5ef - Browse repository at this point
Copy the full SHA eafa5efView commit details -
Remove refcheck test for CIS profiles
The CIS references will now be set automatically based on data in control files. They will not be assigned manually to rule.ymls, therefore they won't be present in rule.ymls, therefore we shouldn't test if they're present there.
Configuration menu - View commit details
-
Copy full SHA for 8d3ee55 - Browse repository at this point
Copy the full SHA 8d3ee55View commit details -
This commit adds a simple unit test for the feature of compiling rule references by adding references based on control file.
Configuration menu - View commit details
-
Copy full SHA for f819d4e - Browse repository at this point
Copy the full SHA f819d4eView commit details -
Remove CIS references from rules
Remove CIS RHEL 7, RHEL 8, RHEL 9 references from rules because they are added automatically based on control files.
Configuration menu - View commit details
-
Copy full SHA for 25e4d24 - Browse repository at this point
Copy the full SHA 25e4d24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2447bf0 - Browse repository at this point
Copy the full SHA 2447bf0View commit details -
Reduce code complexity by extracting a code to a method.
Configuration menu - View commit details
-
Copy full SHA for 35ebe04 - Browse repository at this point
Copy the full SHA 35ebe04View commit details -
Reduce code complexity by extracting a code to a new function.
Configuration menu - View commit details
-
Copy full SHA for 8b83c70 - Browse repository at this point
Copy the full SHA 8b83c70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33dd8ad