-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMP-2372: Remove info override for virtual syscall rules #11544
CMP-2372: Remove info override for virtual syscall rules #11544
Conversation
The STIG has controls that ensure virtual system calls are disabled, because they pose a security risk. However, the rule was previously overridden to always inform users, instead of actually checking the functionality was disabled. This commit removes the override so that we evaluate the kernel argument appropriately. If a user still needs to disable this check (e.g., to make it easier to run 32 bit applications) then they can still exclude the rule using a TailoredProfile.
/test |
@rhmdnd: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-aws-rhcos4-stig |
/test e2e-aws-rhcos4-high |
Code Climate has analyzed commit cb6cd30 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The RHCOS4 high and moderate profile failures are due to unrelated issues we're tracking in separate fixes. |
Adding @BhargaviGudi for review. |
/hold for test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Just pending pre-merge tests.
Verification passed with 4.16.0-0.nightly-2024-02-08-073857 + compliance-operator with compliance-operator code Please find the testing details below
|
/unhold |
The STIG has controls that ensure virtual system calls are disabled,
because they pose a security risk. However, the rule was previously
overridden to always inform users, instead of actually checking the
functionality was disabled.
This commit removes the override so that we evaluate the kernel argument
appropriately. If a user still needs to disable this check (e.g., to
make it easier to run 32 bit applications) then they can still exclude
the rule using a TailoredProfile.