Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCP: Fix e2e remediation for container_security_operator_exists #11545

Merged
merged 1 commit into from
Feb 13, 2024
Merged

OCP: Fix e2e remediation for container_security_operator_exists #11545

merged 1 commit into from
Feb 13, 2024

Conversation

Vincent056
Copy link
Contributor

We need to update the e2e remediation for container_security_operator_exists, so the CI works properly.

@Vincent056
Copy link
Contributor Author

/test

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 5, 2024

@Vincent056: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test 4.13-images
  • /test 4.14-images
  • /test 4.15-images
  • /test 4.16-images
  • /test e2e-aws-ocp4-cis
  • /test e2e-aws-ocp4-cis-node
  • /test e2e-aws-ocp4-e8
  • /test e2e-aws-ocp4-high
  • /test e2e-aws-ocp4-high-node
  • /test e2e-aws-ocp4-moderate
  • /test e2e-aws-ocp4-moderate-node
  • /test e2e-aws-ocp4-pci-dss
  • /test e2e-aws-ocp4-pci-dss-node
  • /test e2e-aws-ocp4-stig
  • /test e2e-aws-ocp4-stig-node
  • /test e2e-aws-rhcos4-e8
  • /test e2e-aws-rhcos4-high
  • /test e2e-aws-rhcos4-moderate
  • /test e2e-aws-rhcos4-stig
  • /test images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-ComplianceAsCode-content-master-4.13-images
  • pull-ci-ComplianceAsCode-content-master-4.14-images
  • pull-ci-ComplianceAsCode-content-master-4.15-images
  • pull-ci-ComplianceAsCode-content-master-4.16-images
  • pull-ci-ComplianceAsCode-content-master-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Vincent056
Copy link
Contributor Author

/test e2e-aws-ocp4-stig

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@rhmdnd
Copy link
Collaborator

rhmdnd commented Feb 6, 2024

Looks like this at least worked on 4.14:

helpers.go:808: Result - Name: e2e-stig-container-security-operator-exists - Status: PASS - Severity: medium
helpers.go:881: Rule container_security_operator_exists matched expected result

Might need to verify on 4.15, too.

@rhmdnd
Copy link
Collaborator

rhmdnd commented Feb 7, 2024

Waiting on openshift/release#48529 to land so we can exercise this patch against a 4.15 cluster using CI.

@rhmdnd
Copy link
Collaborator

rhmdnd commented Feb 8, 2024

/test

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 8, 2024

@rhmdnd: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test 4.13-e2e-aws-ocp4-cis
  • /test 4.13-e2e-aws-ocp4-cis-node
  • /test 4.13-e2e-aws-ocp4-e8
  • /test 4.13-e2e-aws-ocp4-high
  • /test 4.13-e2e-aws-ocp4-high-node
  • /test 4.13-e2e-aws-ocp4-moderate
  • /test 4.13-e2e-aws-ocp4-moderate-node
  • /test 4.13-e2e-aws-ocp4-pci-dss
  • /test 4.13-e2e-aws-ocp4-pci-dss-node
  • /test 4.13-e2e-aws-ocp4-stig
  • /test 4.13-e2e-aws-ocp4-stig-node
  • /test 4.13-e2e-aws-rhcos4-e8
  • /test 4.13-e2e-aws-rhcos4-high
  • /test 4.13-e2e-aws-rhcos4-moderate
  • /test 4.13-e2e-aws-rhcos4-stig
  • /test 4.13-images
  • /test 4.14-images
  • /test 4.15-e2e-aws-ocp4-cis
  • /test 4.15-e2e-aws-ocp4-cis-node
  • /test 4.15-e2e-aws-ocp4-e8
  • /test 4.15-e2e-aws-ocp4-high
  • /test 4.15-e2e-aws-ocp4-high-node
  • /test 4.15-e2e-aws-ocp4-moderate
  • /test 4.15-e2e-aws-ocp4-moderate-node
  • /test 4.15-e2e-aws-ocp4-pci-dss
  • /test 4.15-e2e-aws-ocp4-pci-dss-node
  • /test 4.15-e2e-aws-ocp4-stig
  • /test 4.15-e2e-aws-ocp4-stig-node
  • /test 4.15-e2e-aws-rhcos4-e8
  • /test 4.15-e2e-aws-rhcos4-high
  • /test 4.15-e2e-aws-rhcos4-moderate
  • /test 4.15-e2e-aws-rhcos4-stig
  • /test 4.15-images
  • /test 4.16-e2e-aws-ocp4-cis
  • /test 4.16-e2e-aws-ocp4-cis-node
  • /test 4.16-e2e-aws-ocp4-e8
  • /test 4.16-e2e-aws-ocp4-high
  • /test 4.16-e2e-aws-ocp4-high-node
  • /test 4.16-e2e-aws-ocp4-moderate
  • /test 4.16-e2e-aws-ocp4-moderate-node
  • /test 4.16-e2e-aws-ocp4-pci-dss
  • /test 4.16-e2e-aws-ocp4-pci-dss-node
  • /test 4.16-e2e-aws-ocp4-stig
  • /test 4.16-e2e-aws-ocp4-stig-node
  • /test 4.16-e2e-aws-rhcos4-e8
  • /test 4.16-e2e-aws-rhcos4-high
  • /test 4.16-e2e-aws-rhcos4-moderate
  • /test 4.16-e2e-aws-rhcos4-stig
  • /test 4.16-images
  • /test e2e-aws-ocp4-cis
  • /test e2e-aws-ocp4-cis-node
  • /test e2e-aws-ocp4-e8
  • /test e2e-aws-ocp4-high
  • /test e2e-aws-ocp4-high-node
  • /test e2e-aws-ocp4-moderate
  • /test e2e-aws-ocp4-moderate-node
  • /test e2e-aws-ocp4-pci-dss
  • /test e2e-aws-ocp4-pci-dss-node
  • /test e2e-aws-ocp4-stig
  • /test e2e-aws-ocp4-stig-node
  • /test e2e-aws-rhcos4-e8
  • /test e2e-aws-rhcos4-high
  • /test e2e-aws-rhcos4-moderate
  • /test e2e-aws-rhcos4-stig
  • /test images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-ComplianceAsCode-content-master-4.13-images
  • pull-ci-ComplianceAsCode-content-master-4.14-images
  • pull-ci-ComplianceAsCode-content-master-4.15-images
  • pull-ci-ComplianceAsCode-content-master-4.16-images
  • pull-ci-ComplianceAsCode-content-master-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhmdnd
Copy link
Collaborator

rhmdnd commented Feb 8, 2024

/test 4.13-e2e-aws-ocp4-stig
/test 4.15-e2e-aws-ocp4-stig
/test 4.16-e2e-aws-ocp4-stig

@rhmdnd rhmdnd added the OpenShift OpenShift product related. label Feb 8, 2024
yuumasato
yuumasato reviewed Feb 9, 2024
View reviewed changes
Copy link
Member

@yuumasato yuumasato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The OCP tests for 4.13, 4.15 and 4.6 failed to setup.

Only the test on master ran until the end and rule container_security_operator_exists passed.

...s/openshift/risk-assessment/container_security_operator_exists/tests/ocp4/e2e-remediation.sh Outdated Show resolved Hide resolved
@Vincent056
OCP: Fix e2e remediation for container_security_operator_exists
8a9e648 
We need to update the e2e remediation for container_security_operator_exists, so the CI works properly
@rhmdnd
Copy link
Collaborator

rhmdnd commented Feb 13, 2024

/test 4.13-e2e-aws-ocp4-stig
/test 4.15-e2e-aws-ocp4-stig
/test 4.16-e2e-aws-ocp4-stig

rhmdnd
rhmdnd approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Confirming CI is still green before merging.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 13, 2024

Code Climate has analyzed commit 8a9e648 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 13, 2024

@Vincent056: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-stig 6b87581 link true /test e2e-aws-ocp4-stig
ci/prow/4.16-e2e-aws-ocp4-stig 8a9e648 link true /test 4.16-e2e-aws-ocp4-stig

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhmdnd rhmdnd mentioned this pull request Feb 13, 2024
Merged
@rhmdnd
Copy link
Collaborator

rhmdnd commented Feb 13, 2024

STIG failure was fixed in #11543
4.16 failure should be addressed in #11499

@rhmdnd rhmdnd merged commit b537a33 into master Feb 13, 2024
53 of 55 checks passed
@Mab879 Mab879 added this to the 0.1.73 milestone Feb 13, 2024
@Mab879 Mab879 deleted the container_security branch February 13, 2024 20:36
@Mab879 Mab879 added the Infrastructure Our content build system label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuumasato yuumasato yuumasato left review comments

@rhmdnd rhmdnd rhmdnd approved these changes

@xiaojiey xiaojiey Awaiting requested review from xiaojiey

Assignees

@rhmdnd rhmdnd

Labels
Infrastructure Our content build system OpenShift OpenShift product related.
Projects
None yet
Milestone
0.1.73
Development

Successfully merging this pull request may close these issues.
4 participants
@Vincent056 @rhmdnd @yuumasato @Mab879