-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCP: Fix e2e remediation for container_security_operator_exists #11545
Conversation
/test |
@Vincent056: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-aws-ocp4-stig |
Looks like this at least worked on 4.14:
Might need to verify on 4.15, too. |
Waiting on openshift/release#48529 to land so we can exercise this patch against a 4.15 cluster using CI. |
/test |
@rhmdnd: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 4.13-e2e-aws-ocp4-stig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The OCP tests for 4.13, 4.15 and 4.6 failed to setup.
Only the test on master ran until the end and rule container_security_operator_exists
passed.
...s/openshift/risk-assessment/container_security_operator_exists/tests/ocp4/e2e-remediation.sh
Outdated
Show resolved
Hide resolved
We need to update the e2e remediation for container_security_operator_exists, so the CI works properly
6b87581
to
8a9e648
Compare
/test 4.13-e2e-aws-ocp4-stig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Confirming CI is still green before merging.
Code Climate has analyzed commit 8a9e648 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
@Vincent056: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We need to update the e2e remediation for container_security_operator_exists, so the CI works properly.