-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMP-2366: Update service_autofs_disabled default e2e result #11546
CMP-2366: Update service_autofs_disabled default e2e result #11546
Conversation
Since ComplianceAsCode@1ce0c75 landed, this rule is only invoked if the autofs package is installed. By default, at least with OpenShift 4.13+, it isn't installed which means the default result is NOT-APPLICABLE. This commit updates the default testing result for the rule to match what happens in real clusters since we're being more selective about when to run the rule.
/test |
@rhmdnd: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-aws-rhcos4-high |
Code Climate has analyzed commit c970da7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
@rhmdnd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Seems to work as expected:
The other failures in the high profile run are unrelated to this patch and being fixed separately. |
it looks like it passed the test here, I wonder if we need to change the expected test result to versioned Test result. To have test for OCP 4.12 before it reaches end of life, actually since we are not testing CI on 4.12 I think this should be fine. |
working as expected here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Adding @BhargaviGudi for review. |
/hold for test |
/unhold |
/lgtm |
Since
1ce0c75
landed, this rule is only invoked if the autofs package is installed. By
default, at least with OpenShift 4.13+, it isn't installed which means
the default result is NOT-APPLICABLE.
This commit updates the default testing result for the rule to match
what happens in real clusters since we're being more selective about
when to run the rule.