Prevent conflicts in references #11555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a reference type is provided by a control file it shouldn't be set in rule.yml. We add a build time check that interrupts the build if there is a conflict. This check ensures that the references are centralized in control files.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit cdd7439 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 66.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.4% (0.0% change). View more on Code Climate. |
|
/packit retest-failed |
|
/packit retest-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If a reference type is provided by a control file it shouldn't be set in rule.yml. We add a build time check that interrupts the build if there is a conflict.
Rationale:
This check ensures that the references are centralized in control files.
Review Hints:
Add a reference that should be generated by control file to your favorite rule and then build the product. Check that the build fails. For example, add
cis@rhel9: 1.2.3.4toreferences:inlinux_os/guide/system/selinux/selinux_state/rule.ymland run./build_product -d rhel9.