sysctl template: allow skipping of runtime checks #11574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuumasato
added
OpenShift
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
/test e2e-aws-rhcos4-high |
|
/test |
|
@rhmdnd: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test 4.16-e2e-aws-ocp4-high |
|
@rhmdnd The sysctls rules are used in /test e2e-aws-rhcos4-e8 |
When `check_runtime` is false the template will not generate checks for the runtime configuration. By default the runtime checks are always generated. The goal of these rules is to check for the sysctl both disk and runtime configurations. But the way CO checks for runtime sysctls may not be the most reliable. On OCP some sysctls are not represented with fidelity on the openscap pod, despite being correctly configured and in effect in the underlying node OS.
yuumasato
force-pushed
the
remove-runtime-check-for-some-sysctls
branch
from
e60872b
to
0686917
Compare
|
Code Climate has analyzed commit 0686917 and detected 1 issue on this pull request. Here's the issue category breakdown:
Note: there is 1 critical issue. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.4% (0.0% change). View more on Code Climate. |
|
@yuumasato: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-aws-rhcos4-e8 |
rhmdnd
approved these changes
Feb 10, 2024
|
@BhargaviGudi Hi, should be ready for testing. |
|
/hold for test |
|
Verification passed with 4.16.0-0.nightly-2024-02-08-073857 + compliance-operator with compliance-operator code + PR #11574 code
All sysctl rules are passed |
|
/unhold |
BhargaviGudi
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
sysctltemplate:check_runtimeis"false"the template will not generate checks for the runtime configuration.net.core.bpf_jit_hardennet.ipv6.conf.all.accept_ranet.ipv6.conf.all.accept_redirectsnet.ipv6.conf.default.accept_ranet.ipv6.conf.default.accept_redirectsRationale:
Review Hints:
rhco4-highscan with auto-remediation.rhcos4-high