-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sysctl template: allow skipping of runtime checks #11574
sysctl template: allow skipping of runtime checks #11574
Conversation
/test e2e-aws-rhcos4-high |
/test |
@rhmdnd: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 4.16-e2e-aws-ocp4-high |
@rhmdnd The sysctls rules are used in /test e2e-aws-rhcos4-e8 |
When `check_runtime` is false the template will not generate checks for the runtime configuration. By default the runtime checks are always generated. The goal of these rules is to check for the sysctl both disk and runtime configurations. But the way CO checks for runtime sysctls may not be the most reliable. On OCP some sysctls are not represented with fidelity on the openscap pod, despite being correctly configured and in effect in the underlying node OS.
e60872b
to
0686917
Compare
Code Climate has analyzed commit 0686917 and detected 1 issue on this pull request. Here's the issue category breakdown:
Note: there is 1 critical issue. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.4% (0.0% change). View more on Code Climate. |
@yuumasato: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-aws-rhcos4-e8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E testing looks good. Thanks for the fix!
@BhargaviGudi Hi, should be ready for testing. |
/hold for test |
Verification passed with 4.16.0-0.nightly-2024-02-08-073857 + compliance-operator with compliance-operator code + PR #11574 code
All sysctl rules are passed
|
/unhold |
Description:
sysctl
template:check_runtime
is"false"
the template will not generate checks for the runtime configuration.net.core.bpf_jit_harden
net.ipv6.conf.all.accept_ra
net.ipv6.conf.all.accept_redirects
net.ipv6.conf.default.accept_ra
net.ipv6.conf.default.accept_redirects
Rationale:
Review Hints:
rhco4-high
scan with auto-remediation.rhcos4-high