-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use control files to generate references #11594
Conversation
This test tests if a rule.yml contains the specific references. We started to generated these reference types from control files therefore they stop being present in rule.ymls and we can't use this test.
c200553
to
7ab2ade
Compare
Code Climate has analyzed commit 7ab2ade and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
/packit retest-failed |
1 similar comment
/packit retest-failed |
@@ -22,8 +22,6 @@ severity: medium | |||
identifiers: | |||
cce@rhel7: CCE-80548-1 | |||
|
|||
references: | |||
stigid: WA00612 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to remove these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yes, because they don't correspond to any of the STIG profiles that we have in our project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed a similar thing in 1ad84d6
ssg_refcheck_test("rhel9" "ccn_basic" "ccn") | ||
ssg_refcheck_test("rhel9" "ccn_advanced" "ccn") | ||
# This exclude can be removed once enable_authselect has a stigid | ||
ssg_refcheck_test("rhel9" "stig" "stigid" "enable_authselect") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it makes sense to start testing these references are in the final built data stream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the post merge comment, @jan-cerny @Mab879
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some products, there are CTest tests "verify-references-ssg-${PRODUCT}-ds.xml" and "missing-references-ssg-${PRODUCT}-ds.xml". I think we can extend them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #11610
Description:
We will use control files to automatically assign references to rules for these policies:
Consequently, we will remove the test testing that the rule.yml files in git contain the references to these policies.
Rationale:
reduce data duplication, improve consistency
Review Hints:
Build
rhel9
product, then review some of resolved rules and check if the referencesccn
,stigid
andpcidss4
refer to the correct sections of respective control files.