Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError in get_implemented_stigs #11596

Conversation

svet-se
Copy link
Contributor

@svet-se svet-se commented Feb 16, 2024

Description:

  • Fix TypeError

Rationale:

  • Fix TypeError: unhashable type: 'list'. As refs is a list we do not need this snippet

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 16, 2024
Copy link

openshift-ci bot commented Feb 16, 2024

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@svet-se
Copy link
Contributor Author

svet-se commented Feb 16, 2024

@jan-cerny please review this fix as you worked on ssg.build_yaml.Rule.from_yaml

Have a nice day!
Thanks!

@Mab879 Mab879 self-assigned this Feb 16, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@Mab879
Copy link
Member

Mab879 commented Feb 16, 2024

/packit retest-failed

@Mab879 Mab879 added this to the 0.1.73 milestone Feb 16, 2024
@Mab879 Mab879 added the Infrastructure Our content build system label Feb 16, 2024
@Mab879
Copy link
Member

Mab879 commented Feb 16, 2024

/packit retest-failed

@Mab879
Copy link
Member

Mab879 commented Feb 16, 2024

/packit rebuild-failed

@Mab879
Copy link
Member

Mab879 commented Feb 16, 2024

/packit retest-failed

@Mab879
Copy link
Member

Mab879 commented Feb 16, 2024

/packit retest-failed

One more time.
Based on the logs this looks like possible Infra fail.
Otherwise a rebase might be necessary.

@Mab879
Copy link
Member

Mab879 commented Feb 20, 2024

@svet-se Can you please rebase this PR on the latest master?

@svet-se svet-se force-pushed the fix-type-error-in-get-implemented-stigs branch from cf5f79c to 1187d86 Compare February 20, 2024 14:35
@svet-se
Copy link
Contributor Author

svet-se commented Feb 20, 2024

@Mab879 done

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11596

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11596

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11596 make deploy-local

Copy link

codeclimate bot commented Feb 20, 2024

Code Climate has analyzed commit 1187d86 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit e4ed989 into ComplianceAsCode:master Feb 20, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants