-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oauth_or_oauthclient_token_maxage: Use variable for remediation of rule #11603
oauth_or_oauthclient_token_maxage: Use variable for remediation of rule #11603
Conversation
The rule's extended definition checks are leveragin the variable for the check, so the remediation should also use it.
Code Climate has analyzed commit 40817e9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
/test |
@rhmdnd: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 4.13-e2e-aws-ocp4-moderate |
Change looks good to me. CI should confirm the remediation is working. |
Thanks, I forgot to start the CI tets. |
@yuumasato: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The 4.16 failure is unrelated and being fixed in #11499 |
Description:
Rationale:
Review Hints: