-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for non-existent 'build' dir in build_product #11606
Conversation
I guess this would break the Would it be acceptable to just delete Or to condition the [ -d build ] || mkdir build |
/packit retest-failed |
I would go for the condition, less change to what we have today. |
In some cases, especially when built as an RPM, the empty 'build' directory may disappear, causing './build_product' to fail on ./build_product: line 395: cd: build: No such file or directory Fix this by simply creating the directory if it doesn't exist. Signed-off-by: Jiri Jaburek <comps@nomail.dom>
Swapped the code for a simple conditioned |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit f73a444 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
Description:
In some cases, especially when built as an RPM, the empty 'build' directory may disappear, causing
./build_product
to fail onSince we're already removing its content, just remove it completely and re-create it from scratch. The
-f
ofrm
causes it to silently ignore non-existent 'build'.