-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use string
instead of number
in oauth variable
#11613
Use string
instead of number
in oauth variable
#11613
Conversation
/test |
@rhmdnd: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 4.15-e2e-aws-ocp4-stig |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
d4b4790
to
3cb1249
Compare
/test 4.15-e2e-aws-ocp4-stig |
3cb1249
to
eeed8a6
Compare
/test 4.15-e2e-aws-ocp4-stig |
/test 4.15-e2e-aws-ocp4-stig |
Rekicking CI since I think the original change was using the wrong type still. |
I think |
eeed8a6
to
057e0e2
Compare
/test 4.15-e2e-aws-ocp4-stig |
Waiting to get CI results back on another approach |
This may not be what is causing the profile parsing problems. |
Thanks for confirming. Even if they can be string type, we have other variables that use strings for integers (e.g., Are there other advantages or disadvantages to only using strings for everything, even if it's ultimately an integer? |
I think the only difference will be on the type of comparison/checking we want to with the value. Here is the complete list of possible operations: |
@Mab879 I wonder if you know why it is complaining that we have int when we have number as the type. |
I don't have any theories. |
@rhmdnd I still got the CrashLoopBackOff for the profile parser pods. Maybe a rebase needed? Thanks. |
/hold for test |
@rhmdnd I think this needs to be rebased to pick the encoding change |
Recent changes to the oauth token maxage variable introduced it as a number instead of a string or integer, which SCAP is expecting. This commit updates the variable to be a string instead of a number type, so that the resulting datastream is valid and parsable by the compliance oeprator profile parsers. Without this change, content from the latest branch will cause the compliance operator installs to hang because it can't parse the xccdf.
057e0e2
to
a5a2782
Compare
/test 4.15-e2e-aws-ocp4-stig |
Code Climate has analyzed commit a5a2782 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 57.8% (0.0% change). View more on Code Climate. |
Verification pass with 4.16.0-0.nightly-2024-02-26-013420:
|
/unhold |
string
instead of number
in oauth variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
number
is not an invalid type, but given the extended rule definitions, string
is better suited.
Recent changes to the oauth token maxage variable introduced it as a
number instead of a string or integer, which SCAP is expecting. This
commit updates the variable to be an int instead of a number type, so
that the resulting datastream is valid and parsable by the compliance
oeprator profile parsers.
Without this change, content from the latest branch will cause the
compliance operator installs to hang because it can't parse the xccdf.