-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-28797: Clarify banner instructions for RHCOS nodes #11635
Conversation
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
/hold for test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Just pending pre-merge tesing
@rhmdnd The description is good. However, the instructions is not updated. content/linux_os/guide/system/accounts/accounts-banners/banner_etc_issue/rule.yml Lines 133 to 136 in 4879ba6
$ oc get rule upstream-rhcos4-banner-etc-issue -o=jsonpath={.instructions} |
@@ -56,7 +64,8 @@ description: |- | |||
metadata: | |||
labels: | |||
machineconfiguration.openshift.io/role: master | |||
name: 75-master-etc-issue | |||
machineconfiguration.openshift.io/role: worker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A mc can only be applied for one pool at the same time. It is meaningless to add one more label here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The matchExpressions can apply MC for both custom pool and worker pool.
spec:
machineConfigSelector:
matchExpressions:
- {key: machineconfiguration.openshift.io/role, operator: In, values: [worker,infra]}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh - interesting. Is that only applicable to node pools though? I was able to find one example here
The instructions for remediating Linux banners on login was pretty vague for RHCOS nodes. This commit attempts to clarify that by suggesting the users can use the default remediation, and tweak it to fit their use case.
Code Climate has analyzed commit a23ef02 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.8% (0.0% change). View more on Code Climate. |
Verification pass with 4.16.0-0.nightly-2024-03-06-073110 + content ghcr.io/complianceascode/k8scontent:11635:
|
/unhold |
/lgtm |
The instructions for remediating Linux banners on login was pretty vague
for RHCOS nodes. This commit attempts to clarify that by suggesting the
users can use the default remediation, and tweak it to fit their
use case.