-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-28242: Fix remediation for service_debug-shell_disabled #11638
Conversation
/test |
@Vincent056: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-aws-rhcos4-moderate |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vincent056 The rule is templated, can we leverage it?
https://github.com/ComplianceAsCode/content/blob/08ed709ef5f3bc3d25f9926a3f03664d53bbe67d/shared/templates/service_disabled/kubernetes.template
If we remove this file, the templated kubernetes remediations will be used.
yes, I think that's a good point |
/test e2e-aws-rhcos4-moderate |
/hold for test |
Added mask:true to the remediation. Previously the test was still failling after remediation applied, this is due to lack of mask in the remediation.
We already have a templated remediation for service_disabled, we should remove the remediation in the rule and use the templated remediation instead.
Code Climate has analyzed commit 7046452 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.8% (0.0% change). View more on Code Climate. |
verification passed with 4.16.0-0.nightly-2024-02-29-062601 + compliance-operator deployed from PR-489 code
|
/unhold |
Added mask:true to the remediation. Previously the test was still failling after remediation applied, this is due to lack of mask in the remediation.