-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accounts_passwords_pam_tally2_deny_root fix #11676
accounts_passwords_pam_tally2_deny_root fix #11676
Conversation
The rule accounts_passwords_pam_tally2_deny_root was failing oval check eventhough remediation was applied correctly The regex in the OVAL needed simplification
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
@teacup-on-rockingchair the test scenarios on SLE15 are still failing. Can you take a look into it?
|
…ting The deny=NUMBER option is needed so even_deny_root to work ok Added additional regex test in OVAL for simplicity and maintainability, not merged into same regex Fixed remediations to add the deny=NUMBER clause
Code Climate has analyzed commit a489a0e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.8% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen that the Automatus test scenarios are now passing on SLE15. The fail of Automatus on remaining test job is expected because the rule changed in this PR isn't a part of RHEL 8 or RHEL 9 products.
/packit retest-failed |
Description:
Rationale: