Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu2204: cis_level1_workstation: Add missing !package_cups_removed #11715

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

dodys
Copy link
Contributor

@dodys dodys commented Mar 14, 2024

Description:

  • package_cups_removed is a CIS level 1 server and level 2 workstation rule, therefore for level 1 workstation it must not be selected.

Rationale:

  • Ubuntu 22.04 CIS benchmark

@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Mar 14, 2024
@dodys dodys requested a review from a team as a code owner March 14, 2024 17:55
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys requested a review from Mab879 March 14, 2024 17:57
@dodys
Copy link
Contributor Author

dodys commented Mar 14, 2024

@mpurg fyi

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11715
This image was built from commit: 7ee402a

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11715

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11715 make deploy-local

@dodys
Copy link
Contributor Author

dodys commented Mar 14, 2024

@Mab879 hope you don't mind me adding you, but will need someone else to review it for Ubuntu.

Copy link

codeclimate bot commented Mar 14, 2024

Code Climate has analyzed commit 7ee402a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.8% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Mar 14, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Mar 14, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dodys - Happy to help.

LGTM.

@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Mar 14, 2024
@dodys
Copy link
Contributor Author

dodys commented Mar 15, 2024

@dodys - Happy to help.

LGTM.

thanks!

@Mab879
Copy link
Member

Mab879 commented Mar 15, 2024

Overriding CODEOWNERS as @dodys cannot merge his own PRs.

@Mab879 Mab879 merged commit 1b01849 into ComplianceAsCode:master Mar 15, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants