Stabilize resolved profiles #11727
Stabilize resolved profiles #11727
Conversation
Currently, the resolved profiles have random order of items in the selections list. This makes it less convenient to update the profile stability test data, because copying a resolved profile causes shuffling the git diff. This problem is a recent regression. Git bisect shows that it has been broken by 890ce49. The proposed fix is to use a list instead of set so that the original order of elements is preserved. Related to conversation in ComplianceAsCode#11719.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
|
Code Climate has analyzed commit 33e4563 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.3% (0.0% change). View more on Code Climate. |
|
/retest |
1 similar comment
|
/retest |
Hopefully this will be the last shake up since ComplianceAsCode#11727 was merged.
Currently, the resolved profiles have random order of items in the selections list. This makes it less convenient to update the profile stability test data, because copying a resolved profile causes shuffling the git diff. This problem is a recent regression. Git bisect shows that it has been broken by 890ce49. The proposed fix is to use a list instead of set so that the original order of elements is preserved.
Related to conversation in #11719.