Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the metric of the most-used-components #11738

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Honny1
Copy link
Collaborator

@Honny1 Honny1 commented Mar 21, 2024

Description:

This PR changes the metric for the most-used-components subcommand of profile_tool.py. Now Is used count of profiles where the is metric used. Because the previous metric the count of rules multiplied by their occurrence in profiles multiplied by their occurrence in products was misleading.

Review Hints:

To generate a list of the most used components in the rhel9 product:

    $ ./build-scripts/profile_tool.py most-used-components --products rhel9

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 21, 2024
Copy link

openshift-ci bot commented Mar 21, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Honny1 Honny1 changed the title Chnage metric to count of profile insted count of rules Chnage the metric for the most-used-components Mar 21, 2024
@Honny1 Honny1 changed the title Chnage the metric for the most-used-components Chnage the metric of the most-used-components Mar 21, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11738
This image was built from commit: 736e2b8

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11738

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11738 make deploy-local

@Honny1 Honny1 added the enhancement General enhancements to the project. label Mar 21, 2024
Copy link

codeclimate bot commented Mar 21, 2024

Code Climate has analyzed commit 736e2b8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

@Honny1 Honny1 marked this pull request as ready for review March 21, 2024 13:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 21, 2024
@jan-cerny jan-cerny changed the title Chnage the metric of the most-used-components Change the metric of the most-used-components Mar 21, 2024
@Mab879 Mab879 self-assigned this Mar 21, 2024
@Mab879 Mab879 added the Infrastructure Our content build system label Mar 22, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Mar 22, 2024
@Mab879 Mab879 merged commit 7d8a7c6 into ComplianceAsCode:master Mar 22, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancements to the project. Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants