Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMP-2471: Disable rules on s390x #11743

Merged
merged 1 commit into from
Mar 22, 2024
Merged

CMP-2471: Disable rules on s390x #11743

merged 1 commit into from
Mar 22, 2024

Conversation

Vincent056
Copy link
Contributor

There are some ocp rules are not applicable to s390x cluster, this commit disable those rules on s390x arch.

* file_groupowner_ovs_conf_db_lock
* file_groupowner_ovs_sys_id_conf
* file_permissions_cni_conf

There are some ocp rules are not applicable to s390x cluster, this commit disable those rules on s390x arch.
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11743
This image was built from commit: 4d46e95

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11743

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11743 make deploy-local

Copy link

codeclimate bot commented Mar 22, 2024

Code Climate has analyzed commit 4d46e95 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.8% (0.5% change).

View more on Code Climate.

Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

It would be good to have someone from the IBM team ack these excludes and provide some insight into why the need to be excluded.

@nithyaganesan1
Copy link

yes these rules can be disabled for s390x architecture.

  • file_groupowner_ovs_conf_db_lock
  • file_groupowner_ovs_sys_id_conf
  • file_permissions_cni_conf

@rhmdnd rhmdnd merged commit 7a23c33 into master Mar 22, 2024
53 checks passed
@Vincent056 Vincent056 deleted the s390x_disable branch March 26, 2024 15:07
@Mab879 Mab879 added OpenShift OpenShift product related. Update Rule Issues or pull requests related to Rules updates. labels May 16, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants