-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve playbook script and documention #11747
Improve playbook script and documention #11747
Conversation
* Add good error massage if you can't access the ssg module
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the instructions in the doc and the script works fine. I also run the new tests locally and they passed.
if(SSG_PRODUCT_RHEL9) | ||
file(MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/roles") | ||
add_test( | ||
NAME "utils-ansible-playbook-to-role-rhel9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any GitHub CI job that runs this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the requirements to make the tests run.
So the tests in utils/ansible_playbook_to_role.py run.
Code Climate has analyzed commit e8174ec and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.3% (0.0% change). View more on Code Climate. |
/packit retest-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen both tests running in the Build Test on Fedora Latest job.
Description:
utils/ansible_playbook_to_role.py
utils/ansible_playbook_to_role.py
Rationale:
Follow up to #11495
Review Hints:
Follow the steps in the new docs.