-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thin DS tests #11755
Thin DS tests #11755
Conversation
Skipping CI for Draft Pull Request. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failures on Ubuntu 20.04 looks valid, please take a look.
.github/workflows/gate_thin_ds.yml
Outdated
run: pip install pcre2 -r requirements.txt -r test-requirements.txt | ||
- name: Build | ||
run: |- | ||
./build_product \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to build all these products, including the Alibaba and similar? Would it be fine to build just a single product, some of the popular ones that have a large enough capability, eg. RHEL 9?
Code Climate has analyzed commit 0d53550 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.3% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to break the tested properties in some of the thin DSs and the test failed successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks!
Description:
This PR creates tests and workflow to test thin DSs.
Review Hints:
To execute test locally: