Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thin DS tests #11755

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Thin DS tests #11755

merged 2 commits into from
Mar 27, 2024

Conversation

Honny1
Copy link
Collaborator

@Honny1 Honny1 commented Mar 26, 2024

Description:

This PR creates tests and workflow to test thin DSs.

Review Hints:

To execute test locally:

  • Install new test dependency:
pip install pytest-xdist
  • Build Thin DSs:
./build_product fedora --thin
  • Execute test (working directory is root of project}:
python3 -m pytest -n auto tests/test_thin_ds.py

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 26, 2024
Copy link

openshift-ci bot commented Mar 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

github-actions bot commented Mar 26, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Mar 26, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11755
This image was built from commit: 0d53550

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11755

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11755 make deploy-local

@Honny1 Honny1 added the Test Suite Update in Test Suite. label Mar 26, 2024
@Honny1 Honny1 marked this pull request as ready for review March 26, 2024 15:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 26, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Mar 26, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failures on Ubuntu 20.04 looks valid, please take a look.

run: pip install pcre2 -r requirements.txt -r test-requirements.txt
- name: Build
run: |-
./build_product \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to build all these products, including the Alibaba and similar? Would it be fine to build just a single product, some of the popular ones that have a large enough capability, eg. RHEL 9?

Copy link

codeclimate bot commented Mar 27, 2024

Code Climate has analyzed commit 0d53550 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to break the tested properties in some of the thin DSs and the test failed successfully.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks!

@Mab879 Mab879 merged commit 49e0f95 into ComplianceAsCode:master Mar 27, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants