Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up check_eof #11757

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Clean up check_eof #11757

merged 1 commit into from
Mar 27, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Mar 26, 2024

Description:

  1. Use raise SystemExit
  2. Clean up file names
  3. Clean up help text

Rationale:

Clean up the help text

1. Use raise SystemExit
2. Clean up file names
3. Clean up help text
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11757
This image was built from commit: 04a1484

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11757

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11757 make deploy-local

Copy link

codeclimate bot commented Mar 26, 2024

Code Climate has analyzed commit 04a1484 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Mar 27, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to remove some EOF from our Python code and the script detects it and it is able to fix it.

@jan-cerny jan-cerny merged commit de50a60 into ComplianceAsCode:master Mar 27, 2024
44 checks passed
@jan-cerny jan-cerny added this to the 0.1.73 milestone Mar 27, 2024
@Mab879 Mab879 deleted the fix_check_eof branch March 27, 2024 15:38
@Mab879 Mab879 added the Infrastructure Our content build system label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants